feat(lua): sonar item & vehicle part, overmap reveal bindings#8038
Open
shmakota wants to merge 5 commits intocataclysmbn:mainfrom
Open
feat(lua): sonar item & vehicle part, overmap reveal bindings#8038shmakota wants to merge 5 commits intocataclysmbn:mainfrom
shmakota wants to merge 5 commits intocataclysmbn:mainfrom
Conversation
Contributor
|
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
WishDuck
reviewed
Feb 5, 2026
WishDuck
reviewed
Feb 22, 2026
Collaborator
WishDuck
left a comment
There was a problem hiding this comment.
Once PR & fixing merge conflicts is in we are all set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change (The Why)
Lake content is hard to access, and people have been exploiting prospecting pick mechanics to reveal it.
Describe the solution (The How)
Add the long-awaited sonar item & vehicle part. This can be used to scan 7 tiles around the player, and 5 deep. Using this new item, the player can explore and plan underwater expeditions much easier without wasting resources. They can be found either at freshwater research stations, or found already installed in fishing & scuba boats.
Describe alternatives you've considered
Implementing it in C++? We needed the bindings to reveal stuff on the overmap, anyways, so I figured this would be a good usage & example for them.
Unhardcoding the list of underwater location patterns? Would likely require a flag for underwater locations, and wasn't sure of the best way to go about this, so gonna leave it as is for now.
Testing
Spawned in a fishing boat, used it to reveal the underwater terrain nearby.
Additional context
Checklist
Mandatory
closes #1234in Summary of the PR so it can be closed automatically.mainso it won't cause conflict when updatingmainbranch later.Optional
luascope to the PR title.deno task docs:genso the Lua API documentation is updated.